Returning Points in a Row Calculation

Screenshot

Code

return [1,2,3];

Warning Message

WARNING: use the provided 'result' variable to return array results for efficiency.

Solution

A "result" variable is automatically provided.
Fill it with the results and return it, like so:

result[0] = 1;

result[1] = 2;

result[2] = 3;

return result;

Reason

return [1,2,3]; creates an unnecessary Array - this is slower and consumes more memory.

We want to encourage good consistent coding practices and use the same code pattern everywhere.

Before

After

Returning Null Points

Screenshot

Code

return [null,null,null];

Warning Message

WARNING: do not return [null,null,null], instead return null

Solution

use instead: return null;

Reason

Null coordinates are now specified as null instead of [null,null,null].  This is more efficient and simpler to code, as there is no Array involved.

Before

After

Checking Null Points in a Row Calculation

Screenshot

Code

if(override[0] == null || override[1] == null || override[2] == null)

Warning Message

TypeError: Cannot read properties of null (reading ‘0’)

Solution for Version 6 only

This is the future: use this if you don't need to support users on Version 5

use instead:

if(override === null)

Note the use of 3 = signs, not 2.

=== compares both type and value: you want this!

== will do conversions and may not do what you expect.

Backwards Compatible Solution for both

Version 5 and 6

use instead:

if(override === null || override[0] == null || override[1] == null || override[2] == null)

Tip: add override === null to the front of the if statement.

Reason

Null coordinates are now specified as null instead of [null,null,null].  Thus the check should be much simpler, as there is no Array involved anymore.

Before

After

Octal Literals

Screenshot

Code

new Date(2023,10,01);

Warning Message

WARNING: Program failed to compile

SyntaxError: Octal literals are not allowed in strict mode.

Solution

use instead: new Date(2023,10,1);

Reason

The new Javascript does not accept numbers written with a leading zero, eg 01 or 02.

These are known as Octals, and were a common source of confusion.

ie 08 and 09 are invalid, and 010 translates to 8 in decimal.

This was a source of bugs, so Octals are disallowed as a blanket policy.

Before

After

Problems with Omori Library

similar errors are seen as:   ReferenceError: something is not defined

Screenshot

Error Message

ReferenceError: results_best is not defined

Solution

This requires a root upgrade for a newer version of this library.

Contact support to arrange a full root upgrade.

Reason

We have tightened up "global scoping" rules for better coding practices.

In Version 5, scripts imported via require.mx() could access global variables defined in the main calculation code.

This is bad practice and is no longer allowed.